VMD-L Mailing List
From: John Stone (johns_at_ks.uiuc.edu)
Date: Tue Dec 06 2016 - 17:55:01 CST
Thanks for the suggested patches. I'll take a look at them after our
funding renewal site visit is concluded. In general I tend to leave
conditional compilation tests in the source code until I'm sure that we
will never build on a particular target or API ever again. For PowerPC
we're definitely there. For some of the other changes you've suggested,
it will depend on how things go in testing with different build systems.
On Fri, Dec 02, 2016 at 02:42:09PM +0100, FX wrote:
> I have been looking at the macOS-specific code in VMD and there are several very outdated code paths (most of them hidden by ???#if 0???, some that will be avoided at runtime). Some date back to 10.2, which is impressive.
> I propose the attached patch to clean it up. It will not change behavior on any macOS version since 10.7 (Lion), which was released in October 2012. It will make the code clearer, e.g. when trying to debug issues as I am doing now.
> Thanks for considering it,
> PS: would a patch to drop support for PowerPC builds be welcome? The last PowerPC Mac was sold in 2006, and they have been unsupported for both hardware and software for many years now. Again, it would make things clearer.
-- NIH Center for Macromolecular Modeling and Bioinformatics Beckman Institute for Advanced Science and Technology University of Illinois, 405 N. Mathews Ave, Urbana, IL 61801 http://www.ks.uiuc.edu/~johns/ Phone: 217-244-3349 http://www.ks.uiuc.edu/Research/vmd/